Visual Basic in MS Access, Debug / Compile issue.?

[Steve W]

Ok I have a piece of code for printing out a report which works on all of my reports, however I'm attempting to use similar code to print out a new report and it just will not work....It continually comes up with a error message -

Compile Error - Label not defined.

This is the code I'm using....whats wrong with it?

Private Sub Command49_Click()
On Error GoTo Command49_Click


Dim stDocName As String
DoCmd.DoMenuItem acFormBar, acRecordsMenu, acSaveRecord, , acMenuVer70

stDocName = "ParametricJS"
DoCmd.OpenReport stDocName, acNormal

Exit_Command49_Click:
Exit Sub

Err_Command49_Click:
MsgBox Err.Description
Resume Exit_Command49_Click

End Sub

[sharan]

chk out the stDocName = "ParametricJS"

i think it differs for ur new report

[Mark G]

Your on error statment
On Error GoTo Command49_Click

is saying got to line labled "Command49_Click:

You have instead named your target error handler line
Err_Command49_Click

rewrite
On Error GoTo Command49_Click

as

On Error GoTo Err_Command49_Click


You do not need to uniquely name a label in the context of the entire program..... Meaning you can use a simpler line label like Err_Handler: and not include the subroutine name.

You also do not have to label the Exit either


Private Sub Command49_Click()

On Error Goto Err_Handler:

'your code goes here

Exit Sub
Err_Handler:
'Your error handling code goes here

End Sub

I know this is mainly for style points, I feel that this is easier to read. Also you are using event keywords like _Click in your lables which confuses exactly where the Click event begins and ends (in terms of readability)....